Skip to content

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 16, 2022
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Nov 16, 2022
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - probably shouldn't be "feat()" though

@wagnermaciel
Copy link
Contributor Author

@mmalerba Would docs() be more appropriate? Also, here's a quick visual for what the demo looks like now
Screenshot 2022-11-17 at 9 37 45 AM

@mmalerba
Copy link
Contributor

I can't remember if docs shows up in the changelog or not (we probably don't want this to show up since its not public facing docs), test would be a good option too, since its related to manual testing

@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Nov 18, 2022
@wagnermaciel wagnermaciel changed the title feat(material/slider): improve slider demo test(material/slider): improve slider demo Nov 21, 2022
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Nov 21, 2022
@wagnermaciel wagnermaciel merged commit 46d18a0 into angular:main Nov 21, 2022
wagnermaciel added a commit that referenced this pull request Nov 21, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants