Skip to content

fix(material/schematics): ensure mdc migration compatibility with nx #26027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2022
Merged

fix(material/schematics): ensure mdc migration compatibility with nx #26027

merged 1 commit into from
Nov 19, 2022

Conversation

mmalerba
Copy link
Contributor

by adding missing "multiselect": true in the x-prompt for the components property

@mmalerba
fix(material/schematics): ensure mdc migration compatibility with nx
3bcabd1 
by adding missing `"multiselect": true` in the x-prompt for the
`components` property
@mmalerba mmalerba requested a review from clydin November 18, 2022 21:40
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 18, 2022
crisbeto
crisbeto approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clydin
clydin approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not required by the Angular CLI since multiselect will automatically default to true based on the schema property type. But if other tools don't currently have that logic then it is fine and won't break anything to be explicit.

@clydin clydin removed their assignment Nov 18, 2022
@mmalerba
Copy link
Contributor Author

mmalerba commented Nov 18, 2022 •
edited
Loading

Yeah I'll keep it since i makes the intent more clear and has better tooling support

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2022
@mmalerba mmalerba merged commit d99a7b4 into angular:main Nov 19, 2022
mmalerba added a commit that referenced this pull request Nov 19, 2022
@mmalerba
fix(material/schematics): ensure mdc migration compatibility with nx (#…
ffb5d07 
…26027)

by adding missing `"multiselect": true` in the x-prompt for the
`components` property

(cherry picked from commit d99a7b4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@clydin clydin clydin approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @crisbeto @devversion @clydin