Skip to content

build: update to latest version of parse5 #26086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 25, 2022

Bumps up the version of parse5 to the latest and resolves the various issues.

Fixes #26076.

@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions labels Nov 25, 2022
@@ -53,7 +53,7 @@
"tslib": "0.0.0-TSLIB"
},
"optionalDependencies": {
"parse5": "^5.0.0"
"parse5": "^7.1.2"
Copy link
Member Author

@crisbeto crisbeto Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question: do we want to bump this one to a minor release? It looks like the 7.0.0 release of parse5 was a fairly large one.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 25, 2022
@crisbeto crisbeto marked this pull request as ready for review November 25, 2022 09:25
Bumps up the version of parse5 to the latest and resolves the various issues.

Fixes angular#26076.
@crisbeto crisbeto force-pushed the 26076/parse5-version branch from 0af674a to 81bbf60 Compare November 28, 2022 08:41
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 28, 2022
@crisbeto crisbeto merged commit bbdadef into angular:main Nov 29, 2022
crisbeto added a commit that referenced this pull request Nov 29, 2022
Bumps up the version of parse5 to the latest and resolves the various issues.

Fixes #26076.

(cherry picked from commit bbdadef)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(CDK): parse5 dependency not updated, still points to "^5.0.0"
3 participants