Skip to content

build: switch to new preview deploy github action #26117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

build: switch to new preview deploy github action #26117

merged 1 commit into from
Nov 29, 2022

Conversation

devversion
Copy link
Member

Most of the action logic has been extracted for more reusability, so that can also leverage this setup for AIO previews.

@devversion devversion added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 29, 2022
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 29, 2022
@devversion devversion force-pushed the use-new-preview-deploy-action branch 3 times, most recently from 52efabc to f1456a8 Compare November 29, 2022 15:47
@devversion devversion marked this pull request as ready for review November 29, 2022 16:11
@devversion devversion added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 29, 2022
josephperrott
josephperrott approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should the local version of the tooling (./scripts/github/fetch-workflow-artifact.mjs) be removed as well?

@devversion
build: switch to new preview deploy github action
089113a 
Most of the action logic has been extracted for more reusability, so
that can also leverage this setup for AIO previews.
@devversion devversion force-pushed the use-new-preview-deploy-action branch from f1456a8 to 089113a Compare November 29, 2022 17:41
@devversion
Copy link
Member Author

Good catch, updated!

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 29, 2022
@devversion devversion merged commit 18664ed into angular:main Nov 29, 2022
devversion added a commit that referenced this pull request Nov 29, 2022
@devversion
build: switch to new preview deploy github action (#26117)
b0a72b4 
Most of the action logic has been extracted for more reusability, so
that can also leverage this setup for AIO previews.

(cherry picked from commit 18664ed)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devversion @josephperrott