Skip to content

docs(material/datepicker): mention that its ok to subclass NativeDateAdapter #26119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

docs(material/datepicker): mention that its ok to subclass NativeDateAdapter #26119

merged 1 commit into from
Nov 30, 2022

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels Nov 29, 2022
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 29, 2022
zarend
zarend approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2022
@mmalerba mmalerba self-assigned this Nov 29, 2022
zarend
zarend reviewed Nov 29, 2022
View reviewed changes
@mmalerba mmalerba added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Nov 29, 2022
zarend
zarend approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using inject LGTM, but I think the target is supposed to be minor because it changes the constructor signature in a non-breaking way.

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 29, 2022
@mmalerba
Copy link
Contributor Author

I'm extracting the parameter change to a separate PR since it'll have to go in a major release

@mmalerba mmalerba added target: patch This PR is targeted for the next patch release merge safe and removed target: minor This PR is targeted for the next minor release merge: preserve commits When the PR is merged, a rebase and merge should be performed labels Nov 30, 2022
@mmalerba mmalerba merged commit 2e5fab6 into angular:main Nov 30, 2022
mmalerba added a commit that referenced this pull request Nov 30, 2022
@mmalerba
docs(material/datepicker): mention that its ok to subclass NativeDate…
a697c95 
…Adapter (#26119)

(cherry picked from commit 2e5fab6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

1 more reviewer

@zarend zarend zarend approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @zarend