Skip to content

fix(material/slider): avoid updating tick marks unnecessarily #26322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix(material/slider): avoid updating tick marks unnecessarily #26322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/material/slider/slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ export class MatSlider

/** Updates the width of the tick mark track. */
private _updateTickMarkTrackUI(): void {
if (this._skipUpdate()) {
if (!this.showTickMarks || this._skipUpdate()) {
return;
}

Expand Down Expand Up @@ -883,7 +883,12 @@ export class MatSlider

/** Updates the dots along the slider track. */
_updateTickMarkUI(): void {
if (this.step === undefined || this.min === undefined || this.max === undefined) {
if (
!this.showTickMarks ||
this.step === undefined ||
this.min === undefined ||
this.max === undefined
) {
return;
}
const step = this.step > 0 ? this.step : 1;
Expand Down