Skip to content

build: update sync config to reflect internal config #26668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

build: update sync config to reflect internal config #26668

merged 1 commit into from
Feb 21, 2023

Conversation

devversion
Copy link
Member

As of the MDC list token PR, the sync configs are slightly out of sync. This commit fixes it.

@devversion
build: update sync config to reflect internal config
df0181e 
As of the MDC list token PR, the sync configs are slightly
out of sync. This commit fixes it.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Feb 21, 2023
josephperrott
josephperrott approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ideally we would track this somehow, but I am not sure how to go about that most effectively.

@devversion
Copy link
Member Author

yeah, I added an internal presubmit check when the Copybara config is adjusted. Long-term we could sync it using an internal service, but that's not really a priority. The presubmit check should be sufficient (as this changes rarely anyway)

@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Feb 21, 2023
@angular-robot angular-robot bot merged commit 054c8ee into angular:main Feb 21, 2023
angular-robot bot pushed a commit that referenced this pull request Feb 21, 2023
@devversion
build: update sync config to reflect internal config (#26668)
f53c6c0 
As of the MDC list token PR, the sync configs are slightly
out of sync. This commit fixes it.

(cherry picked from commit 054c8ee)
@gregmagolan gregmagolan mentioned this pull request Mar 8, 2023
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devversion @josephperrott