fix(material/core): allow keyboard navigation to disabled options #26745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
zarend
force-pushed
the
disabled-mat-option
branch
from
88a9c8b to
96c3d59
Compare
zarend
changed the title
zarend
requested review from
crisbeto,
devversion and
josephperrott
as code owners
crisbeto
reviewed
Mar 10, 2023
crisbeto
approved these changes
Mar 14, 2023
zarend
force-pushed
the
disabled-mat-option
branch
from
96c3d59 to
552f7a5
Compare
zarend
force-pushed
the
disabled-mat-option
branch
2 times, most recently
from
a8050ab to
99f7607
Compare
|
since this was reviewed, refactored option.scss so that selector targets only what it needs to target rather than using * selector |
zarend
force-pushed
the
disabled-mat-option
branch
from
99f7607 to
11052ed
Compare
Allow keyboard navigation to disabled options of Select and Autocomplete component. Align with WAI ARIA instructions for list options from [Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/). Fix accessibility issues where some screen readers are not able to navigate to disabled options. The user can focus disabled options using keyboard, but the user cannot click disabled options.
zarend
force-pushed
the
disabled-mat-option
branch
from
11052ed to
97dd43d
Compare
|
Fix selector for disabled pseudo checkbox. 🤦 ✔️ |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow keyboard navigation to disabled options of Select and Autocomplete
component. Align with WAI ARIA instructions for list options from
Developing a Keyboard
Interface.
Fix accessibility issues where some screen readers are not able to navigate
to disabled options.
The user can focus disabled options using keyboard, but the user cannot
click disabled options.