Skip to content

build: remove ts-node forking bug workaround #26756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

devversion
Copy link
Member

In the past, ts-node had a bug that prevented forking processes when used in combination with --esm.

We contributed a fix upstream to ts-node to fix this, and this commit updates to the latest version so that we can simplify our ng-dev invocation. TypeStrong/ts-node@32d07e2

@devversion devversion added the target: patch This PR is targeted for the next patch release label Mar 9, 2023
@devversion devversion requested a review from crisbeto March 9, 2023 09:10
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 9, 2023
In the past, `ts-node` had a bug that prevented forking processes
when used in combination with `--esm`.

We contributed a fix upstream to `ts-node` to fix this, and this
commit updates to the latest version so that we can simplify our
`ng-dev` invocation. TypeStrong/ts-node@32d07e2
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Mar 9, 2023
@angular-robot angular-robot bot merged commit 5d41978 into angular:main Mar 9, 2023
angular-robot bot pushed a commit that referenced this pull request Mar 9, 2023
In the past, `ts-node` had a bug that prevented forking processes
when used in combination with `--esm`.

We contributed a fix upstream to `ts-node` to fix this, and this
commit updates to the latest version so that we can simplify our
`ng-dev` invocation. TypeStrong/ts-node@32d07e2

(cherry picked from commit 5d41978)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants