refactor(material/progress-bar): change mat-progress-bar to use MDC's… #26850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
approved these changes
Mar 28, 2023
wagnermaciel
commented
Mar 28, 2023
Comment on lines
+54
to
+63
| --mdc-linear-progress-primary-half: 83.67142%; | ||
| --mdc-linear-progress-primary-full: 200.611057%; | ||
| --mdc-linear-progress-secondary-quarter: 37.651913%; | ||
| --mdc-linear-progress-secondary-half: 84.386165%; | ||
| --mdc-linear-progress-secondary-full: 160.277782%; | ||
| --mdc-linear-progress-primary-half-neg: -83.67142%; | ||
| --mdc-linear-progress-primary-full-neg: -200.611057%; | ||
| --mdc-linear-progress-secondary-quarter-neg: -37.651913%; | ||
| --mdc-linear-progress-secondary-half-neg: -84.386165%; | ||
| --mdc-linear-progress-secondary-full-neg: -160.277782%; |
There was a problem hiding this comment.
I'm not sure what to do about these css variables that were previously getting set to some default values and otherwise can only be configured through an adapter. Should I file a bug with MDC or is it ok to just set these this way?
There was a problem hiding this comment.
You should add a comment about where they are derived from, and how we can eventually get rid of them. Yes file a bug and ideally we can put it in the comment e.g. b/1234789
…e MDC's token API (angular#26643)
wagnermaciel
added
the
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… token API (#26643)