build: generate a new app in ng new test #27062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
angular-robot
bot
added
the
area: build & ci
crisbeto
force-pushed
the
ng-add-standalone-test-rework
branch
6 times, most recently
from
30af224 to
5143586
Compare
Currently the `ng new` integration test uses a pre-generated app which we need to keep up to date. This can cause us to miss changes in the project structure between CLI versions. These changes switch to generating the project on-the-fly and adding Material to it instead. I've only done this for the standalone test to verify the approach, but it should be applied to the `ng add` test as well.
crisbeto
force-pushed
the
ng-add-standalone-test-rework
branch
from
5143586 to
0f5790c
Compare
angular-robot bot
pushed a commit
that referenced
this pull request
May 9, 2023
Currently the `ng new` integration test uses a pre-generated app which we need to keep up to date. This can cause us to miss changes in the project structure between CLI versions. These changes switch to generating the project on-the-fly and adding Material to it instead. I've only done this for the standalone test to verify the approach, but it should be applied to the `ng add` test as well. (cherry picked from commit 9b0d9fd)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ng newintegration test uses a pre-generated app which we need to keep up to date. This can cause us to miss changes in the project structure between CLI versions.These changes switch to generating the project on-the-fly and adding Material to it instead.
I've only done this for the standalone test to verify the approach, but it should be applied to the
ng addtest as well.