fix(material/form-field): fix duplicate announcement of form controls #27102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
|
Deployed dev-app for 6174089 to: https://ng-dev-previews-comp--pr-angular-components-27102-5sraamvn.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
zarend
force-pushed
the
form-field-label-owns
branch
2 times, most recently
from
ba86c59 to
eddb808
Compare
Fix duplicate screen reader announcement of form controls. Remove the aria-owns from the form label. Commit 4191b4d added aria-owns on the label to work around issue in JAWS and NVDA. That commit is from 2017, and it appears the JAWS and NVDA issues have been fixed. Tested on NVDA, JAWS and VoiceOver by verifying that I am able to read the form field's label using screen reader. Tested on both Windows and Firefox. Testing environment: - Windows 10 Enterprise Version 22H2 - Chrome Version 114.0.5735.199 (Official Build) (64-bit) - Firefox 115.0 (64-bit) - NVDA version 2022.3 - JAWS Verison 2020.2006.12 ILM - MacOS 13.4.1 (22F82) - VoiceOver - Chrome Version 114.0.5735.198 (Official Build) (arm64) - Firefox Version 114.0.2 (64-bit) Fix angular#26583
zarend
force-pushed
the
form-field-label-owns
branch
from
eddb808 to
6174089
Compare
devversion
approved these changes
Jul 6, 2023
|
Merging this since the related CL was submitted. |
crisbeto
pushed a commit
that referenced
this pull request
Jul 19, 2023
…#27102) Fix duplicate screen reader announcement of form controls. Remove the aria-owns from the form label. Commit 4191b4d added aria-owns on the label to work around issue in JAWS and NVDA. That commit is from 2017, and it appears the JAWS and NVDA issues have been fixed. Tested on NVDA, JAWS and VoiceOver by verifying that I am able to read the form field's label using screen reader. Tested on both Windows and Firefox. Testing environment: - Windows 10 Enterprise Version 22H2 - Chrome Version 114.0.5735.199 (Official Build) (64-bit) - Firefox 115.0 (64-bit) - NVDA version 2022.3 - JAWS Verison 2020.2006.12 ILM - MacOS 13.4.1 (22F82) - VoiceOver - Chrome Version 114.0.5735.198 (Official Build) (arm64) - Firefox Version 114.0.2 (64-bit) Fix #26583 (cherry picked from commit 5c5e34a)
AnthonyFr75
pushed a commit
to AnthonyFr75/components
that referenced
this pull request
Jul 31, 2023
…angular#27102) Fix duplicate screen reader announcement of form controls. Remove the aria-owns from the form label. Commit 4191b4d added aria-owns on the label to work around issue in JAWS and NVDA. That commit is from 2017, and it appears the JAWS and NVDA issues have been fixed. Tested on NVDA, JAWS and VoiceOver by verifying that I am able to read the form field's label using screen reader. Tested on both Windows and Firefox. Testing environment: - Windows 10 Enterprise Version 22H2 - Chrome Version 114.0.5735.199 (Official Build) (64-bit) - Firefox 115.0 (64-bit) - NVDA version 2022.3 - JAWS Verison 2020.2006.12 ILM - MacOS 13.4.1 (22F82) - VoiceOver - Chrome Version 114.0.5735.198 (Official Build) (arm64) - Firefox Version 114.0.2 (64-bit) Fix angular#26583
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
…angular#27102) Fix duplicate screen reader announcement of form controls. Remove the aria-owns from the form label. Commit 4191b4d added aria-owns on the label to work around issue in JAWS and NVDA. That commit is from 2017, and it appears the JAWS and NVDA issues have been fixed. Tested on NVDA, JAWS and VoiceOver by verifying that I am able to read the form field's label using screen reader. Tested on both Windows and Firefox. Testing environment: - Windows 10 Enterprise Version 22H2 - Chrome Version 114.0.5735.199 (Official Build) (64-bit) - Firefox 115.0 (64-bit) - NVDA version 2022.3 - JAWS Verison 2020.2006.12 ILM - MacOS 13.4.1 (22F82) - VoiceOver - Chrome Version 114.0.5735.198 (Official Build) (arm64) - Firefox Version 114.0.2 (64-bit) Fix angular#26583
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate screen reader announcement of form controls.
Remove the aria-owns from the form label. Commit
zarend@4191b4d added aria-owns on the label to
work around issue in JAWS and NVDA. That commit is from 2017, and it
appears the JAWS and NVDA issues have been fixed.
Tested on NVDA, JAWS and VoiceOver by verifying that I am able to read
the form field's label using screen reader. Tested on both Windows and
Firefox.
Testing environment:
Fix #26583