Skip to content

docs(material/form-field): Use BooleanInput for required and disabled attributes #27139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

docs(material/form-field): Use BooleanInput for required and disabled attributes #27139

merged 1 commit into from
May 23, 2023

Conversation

ahmad-moussawi
Copy link
Contributor

To be consistent with recent docs, BooleanInput is the appropriate type here for required and disabled

@ahmad-moussawi ahmad-moussawi requested a review from jelbourn as a code owner May 23, 2023 07:30
@ahmad-moussawi ahmad-moussawi changed the title Use BooleanInput for required and disabled attributes docs(material/form-field): Use BooleanInput for required and disabled attributes May 23, 2023
crisbeto
crisbeto approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels May 23, 2023
@angular-robot angular-robot bot merged commit 06a26ad into angular:main May 23, 2023
angular-robot bot pushed a commit that referenced this pull request May 23, 2023
@ahmad-moussawi @crisbeto
docs(material/form-field): Use BooleanInput for required and `dis…
76cb6ad 
…abled` attributes (#27139)

(cherry picked from commit 06a26ad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmad-moussawi @crisbeto