Skip to content

fix(material/badge): warn if use with mat-icon #27368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix(material/badge): warn if use with mat-icon #27368

merged 2 commits into from
Jun 28, 2023

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jun 26, 2023

prior this commit there was no warning for matBadge being use with as it is aria-hidden by default which means badge content is invisible to screen readers

fixes #27035

@naaajii naaajii requested a review from jelbourn as a code owner June 26, 2023 19:34
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 26, 2023
crisbeto
crisbeto reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'd say that this is more of a fix than a feature.

@naaajii
fix(material/badge): warn if use with mat-icon
50a395a 
prior this commit there was no warning for matBadge being use with <mat-icon> as it is aria-hidden by default which means badge content is invisible to screen readers

fixes angular#27035
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Jun 27, 2023
@naaajii naaajii changed the title feat(material/badge): warn if use with mat-icon fix(material/badge): warn if use with mat-icon Jun 27, 2023
crisbeto
crisbeto reviewed Jun 27, 2023
View reviewed changes
crisbeto
crisbeto approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 27, 2023
@crisbeto crisbeto self-assigned this Jun 28, 2023
@crisbeto crisbeto merged commit 65c7cad into angular:main Jun 28, 2023
crisbeto pushed a commit that referenced this pull request Jun 28, 2023
@naaajii @crisbeto
fix(material/badge): warn if use with mat-icon (#27368)
5c066ba 
* fix(material/badge): warn if use with mat-icon

prior this commit there was no warning for matBadge being use with <mat-icon> as it is aria-hidden by default which means badge content is invisible to screen readers

fixes #27035

* fixup! fix(material/badge): warn if use with mat-icon

(cherry picked from commit 65c7cad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2023
@naaajii naaajii deleted the fix-27035 branch September 27, 2024 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(badge): Badge should warn when used on an aria-hidden mat-icon
2 participants
@naaajii @crisbeto