Skip to content

fix(material/dialog): css structure change #27510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 6, 2023
Merged

fix(material/dialog): css structure change #27510

merged 6 commits into from
Sep 6, 2023

Conversation

wagnermaciel
Copy link
Contributor

  • change the css structure of the dialog surface and it's children

@wagnermaciel wagnermaciel marked this pull request as ready for review July 25, 2023 16:33
@wagnermaciel wagnermaciel requested a review from devversion as a code owner July 25, 2023 16:33
@wagnermaciel wagnermaciel requested a review from crisbeto July 25, 2023 16:33
crisbeto
crisbeto reviewed Jul 25, 2023
View reviewed changes
@wagnermaciel wagnermaciel requested a review from crisbeto August 3, 2023 15:38
crisbeto
crisbeto reviewed Aug 3, 2023
View reviewed changes
@wagnermaciel wagnermaciel requested a review from crisbeto August 3, 2023 17:47
crisbeto
crisbeto approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion removed their request for review August 7, 2023 12:41
@josephperrott josephperrott removed their request for review August 30, 2023 15:43
@wagnermaciel wagnermaciel requested review from zarend and removed request for andrewseguin and zarend September 1, 2023 14:45
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 1, 2023
@angular-robot angular-robot bot requested a review from crisbeto September 6, 2023 02:35
@wagnermaciel wagnermaciel requested review from zarend and removed request for zarend September 6, 2023 12:06
@wagnermaciel wagnermaciel merged commit cac7a41 into angular:main Sep 6, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

+1 more reviewer

@zarend zarend zarend left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wagnermaciel @crisbeto @zarend