Skip to content

docs(material/tree): delete tree-checklist example. #27577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

docs(material/tree): delete tree-checklist example. #27577

merged 1 commit into from
Sep 22, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Aug 3, 2023

Delete tree-checklist example.

@zarend zarend added docs This issue is related to documentation target: patch This PR is targeted for the next patch release area: material/tree labels Aug 3, 2023
@zarend zarend requested review from jelbourn and BobobUnicorn August 3, 2023 18:14
@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 3, 2023
@zarend zarend force-pushed the remove-tree-checklist-example branch from af3e658 to c543ca9 Compare August 3, 2023 18:15
@zarend
docs(material/tree): delete tree-checklist example.
7e21db1 
Delete tree-checklist example. That's because this example doesn't
correctly follow [ARIA Tree View
interaction](https://www.w3.org/WAI/ARIA/apg/patterns/treeview/) for
selection. A correct solution would use aria-selected or aria-checked.
@zarend zarend force-pushed the remove-tree-checklist-example branch from c543ca9 to 7e21db1 Compare August 3, 2023 18:22
@zarend zarend marked this pull request as ready for review August 3, 2023 18:38
@zarend zarend requested a review from andrewseguin as a code owner August 3, 2023 18:38
@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Sep 22, 2023
@zarend zarend removed the request for review from jelbourn September 22, 2023 16:53
@zarend zarend merged commit 7bb4491 into angular:main Sep 22, 2023
zarend added a commit that referenced this pull request Sep 22, 2023
@zarend
docs(material/tree): delete tree-checklist example. (#27577)
5cd7204 
Delete tree-checklist example. That's because this example doesn't
correctly follow [ARIA Tree View
interaction](https://www.w3.org/WAI/ARIA/apg/patterns/treeview/) for
selection. A correct solution would use aria-selected or aria-checked.

(cherry picked from commit 7bb4491)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

+1 more reviewer

@BobobUnicorn BobobUnicorn BobobUnicorn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/tree docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarend @BobobUnicorn @andrewseguin