refactor(cdk/dialog): changes to accommodate standalone #27693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
devversion,
josephperrott and
jelbourn
as code owners
andrewseguin
approved these changes
Aug 22, 2023
crisbeto
force-pushed
the
cdk-dialog-standalone
branch
from
d25019c to
18d014f
Compare
devversion
approved these changes
Aug 22, 2023
crisbeto
force-pushed
the
cdk-dialog-standalone
branch
from
18d014f to
edc4755
Compare
Reworks the CDK dialog to use a standalone component and to use `providedIn: 'root'` for its providers.
crisbeto
force-pushed
the
cdk-dialog-standalone
branch
from
edc4755 to
b25e28a
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the CDK dialog to use a standalone component and to use
providedIn: 'root'for its providers.