Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(multiple): switch to built-in control flow #27987

Merged
merged 1 commit into from Oct 24, 2023

Conversation

crisbeto
Copy link
Member

Reworks the component internals to use the new built-in control flow instead of ngIf, ngSwitch and ngFor. This has the advantage of not requiring directives to be imported and instantiated.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Oct 24, 2023
@crisbeto crisbeto changed the title pef(multiple): switch to built-in control flow perf(multiple): switch to built-in control flow Oct 24, 2023
@crisbeto crisbeto marked this pull request as ready for review October 24, 2023 05:32
Reworks the component internals to use the new built-in control flow instead of `ngIf`, `ngSwitch` and `ngFor`. This has the advantage of not requiring directives to be imported and instantiated.
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Super excited to see this change!

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2023
@crisbeto crisbeto self-assigned this Oct 24, 2023
@crisbeto crisbeto merged commit e2d9cfa into angular:main Oct 24, 2023
24 of 26 checks passed
crisbeto added a commit that referenced this pull request Oct 24, 2023
Reworks the component internals to use the new built-in control flow instead of `ngIf`, `ngSwitch` and `ngFor`. This has the advantage of not requiring directives to be imported and instantiated.

(cherry picked from commit e2d9cfa)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants