Skip to content

Conversation

crisbeto
Copy link
Member

Reworks the component internals to use the new built-in control flow instead of ngIf, ngSwitch and ngFor. This has the advantage of not requiring directives to be imported and instantiated.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Oct 24, 2023
@crisbeto crisbeto changed the title pef(multiple): switch to built-in control flow perf(multiple): switch to built-in control flow Oct 24, 2023
@crisbeto crisbeto marked this pull request as ready for review October 24, 2023 05:32
Reworks the component internals to use the new built-in control flow instead of `ngIf`, `ngSwitch` and `ngFor`. This has the advantage of not requiring directives to be imported and instantiated.
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Super excited to see this change!

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2023
@crisbeto crisbeto self-assigned this Oct 24, 2023
@crisbeto crisbeto merged commit e2d9cfa into angular:main Oct 24, 2023
crisbeto added a commit that referenced this pull request Oct 24, 2023
Reworks the component internals to use the new built-in control flow instead of `ngIf`, `ngSwitch` and `ngFor`. This has the advantage of not requiring directives to be imported and instantiated.

(cherry picked from commit e2d9cfa)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants