refactor: use enum instead of const enum #28052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmvald
requested review from
devversion,
josephperrott,
mmalerba,
andrewseguin,
crisbeto,
zarend and
jelbourn
as code owners
pmvald
added
target: minor
pmvald
removed request for
jelbourn,
zarend,
josephperrott,
mmalerba and
andrewseguin
devversion
approved these changes
Nov 3, 2023
pmvald
force-pushed
the
remove-const-enums
branch
from
2ab3e7e to
527d8c4
Compare
devversion
approved these changes
Nov 3, 2023
Const enums prevent enabling the `isolatedModules` check which is needed for fast TS compilation based on transpileModule API.
pmvald
force-pushed
the
remove-const-enums
branch
from
527d8c4 to
4a55141
Compare
crisbeto
approved these changes
Nov 3, 2023
|
Caretaker note: The failing internal test seems to be a screenshot test unrelated to ng components. |
pmvald
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Const enums prevent enabling the
isolatedModulescheck which is needed for fast TS compilation based on transpileModule API.This the counterpart of #51670 in Angular repo.