Skip to content

refactor(material/core): switch pseudo checkbox to tokens theming API #28174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

refactor(material/core): switch pseudo checkbox to tokens theming API #28174

merged 1 commit into from
Nov 27, 2023

Conversation

crisbeto
Copy link
Member

Reworks the pseudo checkbox component to be themed through the tokens API.

@crisbeto
refactor(material/core): switch pseudo checkbox to tokens theming API
c53c3cd 
Reworks the pseudo checkbox component to be themed through the tokens API.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 22, 2023
mmalerba
mmalerba approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 23, 2023
@crisbeto crisbeto removed the request for review from andrewseguin November 27, 2023 16:21
@crisbeto crisbeto merged commit 0509be9 into angular:main Nov 27, 2023
crisbeto added a commit that referenced this pull request Nov 27, 2023
@crisbeto
refactor(material/core): switch pseudo checkbox to tokens theming API (…
294d886 
…#28174)

Reworks the pseudo checkbox component to be themed through the tokens API.

(cherry picked from commit 0509be9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @mmalerba