-
Notifications
You must be signed in to change notification settings - Fork 6.8k
perf(cdk/table): Optimize a11y role logic in CdkCell. #28336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(cdk/table): Optimize a11y role logic in CdkCell. #28336
Conversation
@kseamon can you run |
22b0d4b
to
c62d561
Compare
Done! |
c62d561
to
d4fb042
Compare
Rejiggered a bit to account for a few internal cases where the table's role was changing between its constructor and the first cell's constructor. |
3528c80
to
de794e4
Compare
@kseamon looks like this needs a rebase and there's a lint failure. |
de794e4
to
edab25b
Compare
Rebased. The internal CL for this (596613799) is already submitted. Is it possible to handle the lint issue in a fast follow PR? |
@kseamon Yup no problem, we can merge this and fix the lint issue with an immediate followup PR |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This saves just over a tenth of a millisecond per cell in the native TD case and about a twentieth in other cases. Doesn't sound like much, but it adds up in larger tables.