fix(cdk/table): measuring sticky row too early #28393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
commented
Jan 9, 2024
| } | ||
| // Coalesce with other sticky row updates (top/bottom), sticky columns updates | ||
| // (and potentially other changes like column resize). | ||
| this._coalescedStyleScheduler.schedule(() => { |
There was a problem hiding this comment.
This is a pretty big diff, but I just moved the measurements into the schedule call.
andrewseguin
approved these changes
Jan 9, 2024
Fixes that after angular#28356 the table rows were measured too early which caused multiple sticky rows not to work as expected.
crisbeto
force-pushed
the
sticky-table-rows
branch
from
003ca26 to
31fd4cf
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that after #28356 the table rows were measured too early which caused multiple sticky rows not to work as expected.