fix(material-experimental/theming): set up internal form field in M3 #28414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the tokens for the internal form field weren't being provided in M3. Also includes the tokens in the components where the internal form field is used.
crisbeto
added
P3
mmalerba
approved these changes
Jan 12, 2024
| /// Gets the token values for the MDC form field. | ||
| /// @param {Map} $systems The MDC system tokens. | ||
| /// @return {Map} The form field tokens. | ||
| @function _get-form-field-tokens($systems) { |
There was a problem hiding this comment.
should we take in the exclude-hardcoded param as well? the other functions here all take it
There was a problem hiding this comment.
I'm not quite sure what that parameter even does. I think I mostly saw it in MDC's tokens for opacities.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 13, 2024
Fixes that a copy-paste error in angular#28414 broke the M3 filled text field.
crisbeto
added a commit
that referenced
this pull request
Jan 13, 2024
Fixes that a copy-paste error in #28414 broke the M3 filled text field.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the tokens for the internal form field weren't being provided in M3. Also includes the tokens in the components where the internal form field is used.