Skip to content

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Feb 13, 2024

No description provided.

@zarend zarend added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Feb 13, 2024
Copy link

github-actions bot commented Feb 13, 2024

Deployed dev-app for a5cabf1 to: https://ng-dev-previews-comp--pr-angular-components-28586-dev-hy63et7a.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@zarend zarend force-pushed the m3-nav-list branch 2 times, most recently from 305f3a6 to ed3ea57 Compare February 13, 2024 22:37
@zarend zarend changed the title fix(material/list): wip, tokenize active indicator fix(material/list): tokenize active-indicator Feb 13, 2024
Add active state for MatNavList. Implement active state by implementing 2
tokens under mat prefix.

 - mat-list-active-indicator-color
 - mat-list-active-indicator-shape

Only affects list items that are anchor tags.

Does not intend to make visual changes to M2.
@zarend zarend added area: material/list target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 13, 2024
@zarend zarend marked this pull request as ready for review February 13, 2024 22:54
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 14, 2024
@zarend zarend merged commit 09ee075 into angular:main Feb 14, 2024
zarend added a commit that referenced this pull request Feb 14, 2024
* fix(material/list): tokenize active-indicator

Add active state for MatNavList. Implement active state by implementing 2
tokens under mat prefix.

 - mat-list-active-indicator-color
 - mat-list-active-indicator-shape

Only affects list items that are anchor tags.

Does not intend to make visual changes to M2.

* !fixup fix(material/list): tokenize active-indicator

(cherry picked from commit 09ee075)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/list dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants