Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/drag-drop): optionally inject parent drag in preview and placeholder #28750

Merged
merged 1 commit into from Mar 20, 2024

Conversation

crisbeto
Copy link
Member

Fixes a regression from #28633 where using cdkDragPlaceholder or cdkDragPreview without a cdkDrag would throw. Technically this is a no-op, but it appears that folks started depending on the old behavior so these changes bring it back.

Fixes #28744.

…eholder

Fixes a regression from angular#28633 where using `cdkDragPlaceholder` or `cdkDragPreview` without a `cdkDrag` would throw. Technically this is a no-op, but it appears that folks started depending on the old behavior so these changes bring it back.

Fixes angular#28744.
@crisbeto crisbeto removed the request for review from amysorto March 20, 2024 15:40
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 20, 2024
@crisbeto crisbeto merged commit 9343131 into angular:main Mar 20, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Mar 20, 2024
…eholder (#28750)

Fixes a regression from #28633 where using `cdkDragPlaceholder` or `cdkDragPreview` without a `cdkDrag` would throw. Technically this is a no-op, but it appears that folks started depending on the old behavior so these changes bring it back.

Fixes #28744.

(cherry picked from commit 9343131)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(DragDropModule): Dependency Injection issue with CdkDrag combined with CdkVirtualScroll after upgrade
2 participants