fix(cdk/scrolling): fix virtual scrolling jankiness with run coalescing #28846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: can we update the commit message to make it indicate this is not a zoneless-only issue since we can reproduce the problems with zones and run coalescing? |
atscott
approved these changes
Apr 8, 2024
This fixes an issue with the virtual scroll when run coalescing is turned on which caused the virtual scroll viewport to incorrectly determine when items has been rendered. Co-authored-by: Andrew Scott <atscott@google.com>
mmalerba
changed the title
mmalerba
requested review from
devversion,
andrewseguin and
crisbeto
as code owners
crisbeto
approved these changes
Apr 10, 2024
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Apr 17, 2024
…coalescing (angular#28846)" This reverts commit d91d0d4. This broke an app in g3, reverting while we investigate
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Apr 25, 2024
… coalescing (angular#28846)" (angular#28890) This reverts commit ee9abb8.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the virtual scroll when run coalescing is
turned on which caused the virtual scroll viewport to incorrectly
determine when items has been rendered.