Skip to content

refactor(material/checkbox): simplify structural styles #29136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

crisbeto
Copy link
Member

Simplifies the styles for the checkbox to make them smaller and easier to follow.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 29, 2024
@crisbeto crisbeto requested review from amysorto and andrewseguin May 29, 2024 11:06
@@ -6,25 +6,25 @@
// its background color. Since that doesn't work in HCM, this mixin provides an alternative by
// rendering a circle.
@mixin private-high-contrast-list-item-indicator() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles are the same, I just noticed that they weren't indented properly.

@crisbeto crisbeto force-pushed the fork-checkbox branch 4 times, most recently from 752b2cc to f19819b Compare May 29, 2024 15:11
Copy link
Contributor

@amysorto amysorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@crisbeto crisbeto force-pushed the fork-checkbox branch 5 times, most recently from 77fec21 to 14f6665 Compare May 29, 2024 17:45
Simplifies the styles for the checkbox to make them smaller and easier to follow.
@crisbeto crisbeto self-assigned this May 31, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 31, 2024
@crisbeto crisbeto merged commit dbcf35d into angular:main May 31, 2024
crisbeto added a commit that referenced this pull request May 31, 2024
Simplifies the styles for the checkbox to make them smaller and easier to follow.

(cherry picked from commit dbcf35d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants