Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/dialog): Make focus behavior consistent across zoneful/zoneless apps #29192

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix(material/dialog): Make focus behavior consistent across zoneful/zoneless apps #29192

merged 1 commit into from
Jun 10, 2024

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jun 4, 2024

No description provided.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jun 4, 2024
@mmalerba mmalerba force-pushed the dialog-zone branch 3 times, most recently from fc9949a to 6af8a35 Compare June 10, 2024 14:57
@mmalerba mmalerba marked this pull request as ready for review June 10, 2024 14:57
@mmalerba mmalerba requested a review from a team as a code owner June 10, 2024 14:57
@mmalerba mmalerba requested review from amysorto and wagnermaciel and removed request for a team June 10, 2024 14:57
jelbourn
jelbourn approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 10, 2024
@mmalerba mmalerba merged commit 3b32d0e into angular:main Jun 10, 2024
24 checks passed
mmalerba added a commit that referenced this pull request Jun 10, 2024
@mmalerba
fix(material/dialog): Make focus behavior consistent across zoneful/z…
6dd1689 
…oneless apps (#29192)

(cherry picked from commit 3b32d0e)
@hantsy hantsy mentioned this pull request Jul 4, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Jul 4, 2024
Open
@sanjayrajesh sanjayrajesh mentioned this pull request Jul 4, 2024
Open
@hantsy hantsy mentioned this pull request Jul 10, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmalerba @jelbourn @andrewseguin