Elevation classes in M3 #29240
Merged
Elevation classes in M3 #29240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
crisbeto
requested review from
amysorto,
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
force-pushed
the
28618/m3-elevation
branch
from
54f3ca5 to
86fc4e6
Compare
Fixes that we didn't support elevation classes in M3 which was breaking some users. Fixes angular#28618.
The menu has some logic to increase its elevation depending on it depth which hasn't worked since we introduced M3. These changes update it to account for a different base elevation.
crisbeto
force-pushed
the
28618/m3-elevation
branch
from
86fc4e6 to
c6ec508
Compare
andrewseguin
approved these changes
Jun 13, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a couple of fixes that implement the elevation classes for M3 and update some existing components to handle them properly.
Fixes #28618.