Skip to content

Conversation

crisbeto
Copy link
Member

When some calendar inputs change, we need to re-render the entire view (e.g. minDate or dateFilter). This can cause the active cell to lose focus since it's being re-rendered.

These changes schedule the active cell to be re-focused in the cases where the view would be re-rendered.

Fixes #29265.

…rrent view

When some calendar inputs change, we need to re-render the entire view (e.g. `minDate` or `dateFilter`). This can cause the active cell to lose focus since it's being re-rendered.

These changes schedule the active cell to be re-focused in the cases where the view would be re-rendered.

Fixes angular#29265.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 20, 2024
@crisbeto crisbeto requested a review from a team as a code owner June 20, 2024 09:16
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team June 20, 2024 09:16
@crisbeto crisbeto removed the request for review from andrewseguin June 25, 2024 14:39
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2024
@crisbeto crisbeto merged commit e74065a into angular:main Jun 25, 2024
crisbeto added a commit that referenced this pull request Jun 25, 2024
…rrent view (#29287)

When some calendar inputs change, we need to re-render the entire view (e.g. `minDate` or `dateFilter`). This can cause the active cell to lose focus since it's being re-rendered.

These changes schedule the active cell to be re-focused in the cases where the view would be re-rendered.

Fixes #29265.

(cherry picked from commit e74065a)
DBowen33 pushed a commit to DBowen33/components that referenced this pull request Jul 3, 2024
…rrent view (angular#29287)

When some calendar inputs change, we need to re-render the entire view (e.g. `minDate` or `dateFilter`). This can cause the active cell to lose focus since it's being re-rendered.

These changes schedule the active cell to be re-focused in the cases where the view would be re-rendered.

Fixes angular#29265.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(DatePicker): Keyboard focus lost after selecting first date in range (accessibility failure)
2 participants