Skip to content

fix(material/sidenav): not closing on escape key press #29292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(material/sidenav): not closing on escape key press #29292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/material/sidenav/drawer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ export class MatDrawer implements AfterViewInit, AfterContentChecked, OnDestroy
readonly _modeChanged = new Subject<void>();

private _injector = inject(Injector);
private _changeDetectorRef = inject(ChangeDetectorRef);

constructor(
private _elementRef: ElementRef<HTMLElement>,
Expand Down Expand Up @@ -593,6 +594,8 @@ export class MatDrawer implements AfterViewInit, AfterContentChecked, OnDestroy
}
}

// Needed to ensure that the closing sequence fires off correctly.
this._changeDetectorRef.markForCheck();
this._updateFocusTrapState();

return new Promise<MatDrawerToggleResult>(resolve => {
Expand Down