refactor(material/progress-bar): simplify structural styles #29303
+320
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the progress bar styles to be simpler and easier to maintain.
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
amysorto
approved these changes
Jun 24, 2024
| transform: scaleX(0); | ||
|
|
||
| .mdc-linear-progress--indeterminate & { | ||
| left: -145.166611%; |
There was a problem hiding this comment.
where do these percentage values come from? Is it just what MDC used?
There was a problem hiding this comment.
Yep, they were basically hardcoded as CSS variables in MDC. I just inlined them since nobody is realistically changing those variables.
crisbeto
added a commit
that referenced
this pull request
Jun 24, 2024
Reworks the progress bar styles to be simpler and easier to maintain. (cherry picked from commit e92e9cc)
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
…29303) Reworks the progress bar styles to be simpler and easier to maintain.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the progress bar styles to be simpler and easier to maintain.