Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 30, 2024

Fixes that the slide toggle was triggering the :active styles for the entire container, even though only parts of it are interactive.

Fixes #29483.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 30, 2024
@crisbeto crisbeto requested a review from a team as a code owner July 30, 2024 07:44
@crisbeto crisbeto requested review from amysorto and mmalerba and removed request for a team July 30, 2024 07:44
@crisbeto crisbeto force-pushed the 29483/slide-toggle-clickable-area branch 2 times, most recently from df76492 to c42022b Compare July 30, 2024 12:11
…tainer

Fixes that the slide toggle was triggering the `:active` styles for the entire container, even though only parts of it are interactive.

Fixes angular#29483.
@crisbeto crisbeto force-pushed the 29483/slide-toggle-clickable-area branch from c42022b to 4da0ca1 Compare July 30, 2024 12:38
@crisbeto crisbeto changed the title fix(material/slide-toggle): increase clickable area fix(material/slide-toggle): don't trigger active state for entire container Jul 30, 2024
@crisbeto crisbeto requested a review from andrewseguin July 30, 2024 12:39
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2024
@crisbeto crisbeto merged commit 5892acf into angular:main Jul 30, 2024
22 of 24 checks passed
crisbeto added a commit that referenced this pull request Jul 30, 2024
…tainer (#29514)

Fixes that the slide toggle was triggering the `:active` styles for the entire container, even though only parts of it are interactive.

Fixes #29483.

(cherry picked from commit 5892acf)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(slide-toggle): Clicking on mat-slide-toggle element does not toggles the input, but sets :active pseudo selector visually indicating a click
2 participants