Skip to content

chore(demo): fix select demo #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2017
Merged

chore(demo): fix select demo #2959

merged 1 commit into from
Feb 8, 2017

Conversation

kara
Copy link
Contributor

@kara kara commented Feb 7, 2017

Demo was still using the value of an option that was later replaced. This fixes the setValue function so it actually works.

@kara kara requested a review from tinayuangao February 7, 2017 03:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2017
tinayuangao
tinayuangao approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 7, 2017
@tinayuangao tinayuangao merged commit 1a89a08 into angular:master Feb 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kara @tinayuangao @googlebot