fix(cdk/tree): react properly to expansion changes #29751
+440
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobobUnicorn
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
crisbeto
reviewed
Sep 18, 2024
crisbeto
reviewed
Sep 18, 2024
BobobUnicorn
force-pushed
the
fix/cdk-tree-synchronous-expansion
branch
from
c1115f6 to
433e357
Compare
crisbeto
reviewed
Oct 4, 2024
| } | ||
|
|
||
| /** @docs-private */ | ||
| @Directive({ |
There was a problem hiding this comment.
If this is private, do we need a separate component for it?
There was a problem hiding this comment.
I'm not really sure of another way to hook into the onInit for the directive here, though I think ultimately removing mostRecentTreeNode would solve this issue (e.g. doing data passing through injection)
BobobUnicorn
force-pushed
the
fix/cdk-tree-synchronous-expansion
branch
from
1faed45 to
8b1d559
Compare
Open
1 task
crisbeto
approved these changes
Nov 15, 2024
BobobUnicorn
force-pushed
the
fix/cdk-tree-synchronous-expansion
branch
from
b138b69 to
cb4edf0
Compare
|
fixed the merge conflict |
|
Hi there 👋 Just wanted to gently check in on this PR. It’s been a while since the last update, and I was wondering if there’s anything blocking progress. Totally understand if priorities have shifted—just hoping to keep this on the radar. Thanks again for all the work so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29669. This converts parts of the rendering pipeline to use signals which allows Angular to properly detect changes to the underlying data which may be caused by rendering new nodes. rxjs didn't handle this correctly as the data subscriptions were only set after the initial callback was run, causing partial updates.