docs: consolidate theming guides #29988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
andrewseguin
added
the
target: rc
wagnermaciel
reviewed
Nov 8, 2024
| @@ -26,7 +26,7 @@ The Angular Material `ng add` schematic helps you set up an Angular CLI project | |||
|
|
|||
| - Ensure [project dependencies](./getting-started#step-1-install-angular-material-angular-cdk-and-angular-animations) are placed in `package.json` | |||
| - Enable the [BrowserAnimationsModule](./getting-started#step-2-configure-animations) in your app module | |||
| - Add either a [prebuilt theme](./theming#pre-built-themes) or a [custom theme](./theming#defining-a-custom-theme) | |||
There was a problem hiding this comment.
Do these links no longer exist?
There was a problem hiding this comment.
The first one does, but the second doesn't. We could just link to our theming guide but Im not sure if theres much value here linking. It seemed self-explanatory that the schematic is adding a theme in general 🤷♂️
wagnermaciel
approved these changes
Nov 8, 2024
andrewseguin
added a commit
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Andrew Seguin <andrewseguin@google.com> (cherry picked from commit 02d703b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces existing guides for themes and styles and consolidates guidance into the single Theming guide.
Will need to do some work on material.angular.io to make sure existing links still work for the deleted guides (redirect back to v18)