Skip to content

Conversation

kara
Copy link
Contributor

@kara kara commented Feb 9, 2017

r: @mmalerba

Related to #2999

@kara kara requested a review from mmalerba February 9, 2017 18:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2017
@kara kara mentioned this pull request Feb 9, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -69,8 +69,27 @@ as shown in the example).
</md-list>
```

### Lists with icons

To add an icon to your list item, use the `md-list-icon` attribute.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use the mat- prefix from now on?

Copy link
Contributor Author

@kara kara Feb 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most people will want to use md- in their templates, unless they are using both Angular Material and AngularJS Material. The mat prefix is only universal for overriding classes.

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 9, 2017
@tinayuangao tinayuangao merged commit 1a854e7 into angular:master Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants