fix(cdk/overlay): avoid issues with overlapping backdrop removals #30474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
Prior to angular#30179 the overlay ref was able to handle multiple backdrops being removed at the same time, because we didn't need to retain any state about them, aside from the DOM node. After the switch to the renderer that's no longer the case, because we also retain the event cleanup functions. This is a problem, because they can end up overriding each other and causing events to be dropped incorrectly. These changes move the backdrop-related logic to a new `BackdropRef` class to make the removal process easier to manage, clean up the `overlay-ref.ts` a bit and resolve the issue. Fixes angular#30426.
crisbeto
force-pushed
the
30426/overlay-backdrop-cleanup
branch
from
8243c6f to
323c59a
Compare
crisbeto
changed the title
| clearTimeout(this._fallbackTimeout); | ||
| this._cleanupTransitionEnd?.(); | ||
| this._cleanupTransitionEnd = this._renderer.listen(element, 'transitionend', this.dispose); | ||
| this._fallbackTimeout = setTimeout(this.dispose, 500); |
There was a problem hiding this comment.
Feels like this should go just below the following comment about removing after a delay
andrewseguin
approved these changes
Feb 12, 2025
|
The changes were merged into the following branches: main, 19.1.x |
crisbeto
added a commit
that referenced
this pull request
Feb 12, 2025
…0474) Prior to #30179 the overlay ref was able to handle multiple backdrops being removed at the same time, because we didn't need to retain any state about them, aside from the DOM node. After the switch to the renderer that's no longer the case, because we also retain the event cleanup functions. This is a problem, because they can end up overriding each other and causing events to be dropped incorrectly. These changes move the backdrop-related logic to a new `BackdropRef` class to make the removal process easier to manage, clean up the `overlay-ref.ts` a bit and resolve the issue. Fixes #30426. (cherry picked from commit 6434841)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #30179 the overlay ref was able to handle multiple backdrops being removed at the same time, because we didn't need to retain any state about them, aside from the DOM node. After the switch to the renderer that's no longer the case, because we also retain the event cleanup functions. This is a problem, because they can end up overriding each other and causing events to be dropped incorrectly.
These changes move the backdrop-related logic to a new
BackdropRefclass to make the removal process easier to manage, clean up theoverlay-ref.tsa bit and resolve the issue.Fixes #30426.