Skip to content

Conversation

crisbeto
Copy link
Member

Removes the NoopAnimationsModule from the tests generated by ng generate since it requires the animations module to be installed.

Fixes #30560.

…tests

Removes the `NoopAnimationsModule` from the tests generated by `ng generate` since it requires the animations module to be installed.

Fixes angular#30560.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 27, 2025
@crisbeto crisbeto requested a review from a team as a code owner February 27, 2025 10:32
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team February 27, 2025 10:32
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 28, 2025
@crisbeto crisbeto removed the request for review from andrewseguin February 28, 2025 21:13
@crisbeto crisbeto merged commit 31c4dad into angular:main Feb 28, 2025
21 of 23 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Feb 28, 2025
…tests (#30562)

Removes the `NoopAnimationsModule` from the tests generated by `ng generate` since it requires the animations module to be installed.

Fixes #30560.

(cherry picked from commit 31c4dad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(nav): NoopAnimationsModule in @angular/material:nav test doesn't work when animation module isn't added
2 participants