Skip to content

Conversation

ok7sai
Copy link
Member

@ok7sai ok7sai commented May 15, 2025

No description provided.

@ok7sai ok7sai requested a review from wagnermaciel May 15, 2025 22:56
@ok7sai ok7sai requested review from a team as code owners May 15, 2025 22:56
@ok7sai ok7sai requested review from adolgachev and mmalerba and removed request for a team May 15, 2025 22:56
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label May 15, 2025
@ok7sai ok7sai added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label May 15, 2025
Copy link

github-actions bot commented May 15, 2025

Deployed dev-app for 1f2ebfc to: https://ng-dev-previews-comp--pr-angular-components-31134-dev-pemcmxw4.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@ok7sai ok7sai force-pushed the ng-aria-accordion branch from dac077e to 19218fc Compare May 15, 2025 23:02
@ok7sai ok7sai changed the title feat(cdk-experimental/accordion): add acordion directives, example, and tests feat(cdk-experimental/accordion): add accordion directives, example, and tests May 15, 2025
@ok7sai ok7sai force-pushed the ng-aria-accordion branch 3 times, most recently from d112ad0 to a9a1651 Compare May 15, 2025 23:55
@mmalerba
Copy link
Contributor

In the demo I see that if I:

  • turn multi off
  • select just item 2 in the select
  • click item 1

It toggles item 2 closed even though item 2's trigger is disabled. Is that the correct behavior? (genuinely not sure). I think it feels odd to me because the intent of the disabled trigger is like "hey user, you can't change this", but then if they toggle a different item they actually can

@ok7sai ok7sai force-pushed the ng-aria-accordion branch from a9a1651 to 1f2ebfc Compare May 16, 2025 21:44
@ok7sai
Copy link
Member Author

ok7sai commented May 16, 2025

In the demo I see that if I:

  • turn multi off
  • select just item 2 in the select
  • click item 1

It toggles item 2 closed even though item 2's trigger is disabled. Is that the correct behavior? (genuinely not sure). I think it feels odd to me because the intent of the disabled trigger is like "hey user, you can't change this", but then if they toggle a different item they actually can

You are absolutely correct. Agree that the expansion state for a disabled trigger shouldn't be changed. Fixed in the Expansion behavior to ensure the disabled triggers are excluded from the state changes.

@devversion devversion removed the request for review from a team May 19, 2025 10:28
@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 20, 2025
@ok7sai ok7sai removed request for adolgachev and mmalerba May 20, 2025 20:39
@ok7sai ok7sai removed the target: rc This PR is targeted for the next release-candidate label May 20, 2025
@ok7sai ok7sai added target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels May 20, 2025
@ok7sai ok7sai merged commit 4f9ab21 into angular:main May 20, 2025
31 of 34 checks passed
@ok7sai ok7sai deleted the ng-aria-accordion branch June 16, 2025 21:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants