Skip to content

Conversation

crisbeto
Copy link
Member

Fixes that the MatDialogOpener was using the NoopAnimationsModule to disable animations which requires user to have @angular/animations installed.

These changes switch to using MATERIAL_ANIMATIONS in the MatTestDialogOpenerModule and setting the animation durations to zero in case the module isn't used.

Fixes #31145.

Fixes that the `MatDialogOpener` was using the `NoopAnimationsModule` to disable animations which requires user to have `@angular/animations` installed.

These changes switch to using `MATERIAL_ANIMATIONS` in the `MatTestDialogOpenerModule` and setting the animation durations to zero in case the module isn't used.

Fixes angular#31145.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 20, 2025
@crisbeto crisbeto requested a review from a team as a code owner May 20, 2025 07:06
@crisbeto crisbeto requested review from adolgachev and mmalerba and removed request for a team May 20, 2025 07:06
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 20, 2025
@crisbeto crisbeto merged commit 2971f13 into angular:main May 20, 2025
26 of 29 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x, 20.0.x

crisbeto added a commit that referenced this pull request May 20, 2025
Fixes that the `MatDialogOpener` was using the `NoopAnimationsModule` to disable animations which requires user to have `@angular/animations` installed.

These changes switch to using `MATERIAL_ANIMATIONS` in the `MatTestDialogOpenerModule` and setting the animation durations to zero in case the module isn't used.

Fixes #31145.

(cherry picked from commit 2971f13)
crisbeto added a commit that referenced this pull request May 20, 2025
Fixes that the `MatDialogOpener` was using the `NoopAnimationsModule` to disable animations which requires user to have `@angular/animations` installed.

These changes switch to using `MATERIAL_ANIMATIONS` in the `MatTestDialogOpenerModule` and setting the animation durations to zero in case the module isn't used.

Fixes #31145.

(cherry picked from commit 2971f13)
crisbeto added a commit to crisbeto/material2 that referenced this pull request May 21, 2025
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/dialog target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(dialog): @angular/animations package still required to use MatDialogHarness
2 participants