Skip to content

fix(material/button-toggle): simplify divider color #31214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025
Merged

fix(material/button-toggle): simplify divider color #31214

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39b2235
fix(material/button-toggle): simplify divider color
andrewseguin May 24, 2025
5ab9805
refactor: lint
andrewseguin May 24, 2025
90bec7e
refactor: lint
May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/material/button-toggle/_m2-button-toggle.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@use 'sass:map';
@use 'sass:meta';
@use '../core/theming/theming';
@use '../core/theming/inspection';
@use '../core/style/sass-utils';
Expand All @@ -21,18 +20,6 @@

// Tokens that can be configured through Angular Material's color theming API.
@function get-color-tokens($theme) {
$theme-divider-color: inspection.get-theme-color($theme, system, outline);

// By default the theme usually has an rgba color for the dividers, which can
// stack up with the background of a button toggle. This can cause the border
// of a selected toggle to look different from an unselected one. We use a solid
// color to ensure that the border always stays the same.
$divider-color: if(
meta.type-of($theme-divider-color) == color,
theming.private-rgba-to-hex(
$theme-divider-color, inspection.get-theme-color($theme, system, surface)),
$theme-divider-color);

@return (
button-toggle-background-color: inspection.get-theme-color($theme, system, surface),
button-toggle-disabled-selected-state-background-color:
Expand All @@ -43,7 +30,7 @@
inspection.get-theme-color($theme, system, surface),
button-toggle-disabled-state-text-color:
inspection.get-theme-color($theme, foreground, disabled-button),
button-toggle-divider-color: $divider-color,
button-toggle-divider-color: inspection.get-theme-color($theme, system, outline),
button-toggle-legacy-disabled-selected-state-background-color:
inspection.get-theme-color($theme, background, selected-disabled-button),
button-toggle-legacy-disabled-state-background-color:
Expand Down
Loading