fix(material/stepper): generalize stepper aria roles #31256
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
force-pushed
the
vertical-stepper-aria-roles-update
branch
from
6a0d1e9 to
974f372
Compare
Updates Angular Components Material Stepper to use general aria roles like group, region, button as opposed to tab, tablist, tabpanel as this doesn't serve the vertical stepper correctly. Fixes b/361783174
essjay05
force-pushed
the
vertical-stepper-aria-roles-update
branch
from
974f372 to
36b38e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Material Stepper to use general aria roles like group, region, button as opposed to tab, tablist, tabpanel as this doesn't serve the vertical stepper correctly.
Before screenshot
Before lighthouse screenshot
After screenshot
After lighthouse screenshot
Fixes b/361783174