Skip to content

fix(cdk/listbox): coerce tabindex value #31597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2025
Merged

fix(cdk/listbox): coerce tabindex value #31597

merged 1 commit into from
Jul 26, 2025

Conversation

crisbeto
Copy link
Member

Fixes that the CDK listbox option wasn't coercing its tabindex value.

Fixes #31595.

@crisbeto crisbeto requested a review from a team as a code owner July 25, 2025 07:02
@crisbeto crisbeto requested review from adolgachev and ok7sai and removed request for a team July 25, 2025 07:02
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 25, 2025
@crisbeto
fix(cdk/listbox): coerce tabindex value
3e2ee4b 
Fixes that the CDK listbox option wasn't coercing its `tabindex` value.

Fixes angular#31595.
@crisbeto crisbeto force-pushed the 31595/listbox-tabindex branch from e446c04 to 3e2ee4b Compare July 25, 2025 07:11
@crisbeto crisbeto removed the request for review from ok7sai July 26, 2025 04:19
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 26, 2025
@crisbeto crisbeto merged commit c386d0e into angular:main Jul 26, 2025
24 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 20.1.x

crisbeto added a commit that referenced this pull request Jul 26, 2025
@crisbeto
fix(cdk/listbox): coerce tabindex value (#31597)
b5fb4cb 
Fixes that the CDK listbox option wasn't coercing its `tabindex` value.

Fixes #31595.

(cherry picked from commit c386d0e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adolgachev adolgachev adolgachev approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/listbox target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(CdkOption): tabindex does not allow string
3 participants
@crisbeto @adolgachev @wagnermaciel