fix(material/chips): remove visible overflow for labels #31679
Merged
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
force-pushed
the
chips-overflow
branch
from
a418d82 to
d45ded8
Compare
adolgachev
added
Accessibility
|
Deployed dev-app for 0d31065 to: https://ng-dev-previews-comp--pr-angular-components-31679-dev-7j5w7fkg.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for 0d31065 to: https://ng-dev-previews-comp--pr-angular-components-31679-docs-vf7t5e0e.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
chips-overflow
branch
from
2809aca to
f9ac3dd
Compare
adolgachev
changed the title
adolgachev
force-pushed
the
chips-overflow
branch
from
4e83bd3 to
e4cea72
Compare
adolgachev
requested review from
mmalerba,
ok7sai and
crisbeto
and removed request for
a team and
ok7sai
crisbeto
reviewed
Sep 15, 2025
adolgachev
force-pushed
the
chips-overflow
branch
from
57fb305 to
78d04bc
Compare
adolgachev
removed
the
action: global presubmit
adolgachev
force-pushed
the
chips-overflow
branch
from
78d04bc to
0d31065
Compare
andrewseguin
approved these changes
Sep 23, 2025
adolgachev
removed
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26584 and b/221946733 by moving the overridden visible overflow for chip labels to the strong focus mixins. This will let chip labels be correctly truncated (instead of overflowing) if strong focus is not applied (as desired by the community) while preserving strong focus indicators.
Will revisit redoing the structure of the chips to allow for strong focus indicators without having this override at all in near future as part of b/446709063.