fix(cdk/menu): disabled behavior fixes for menu item #31721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues with the disabled behavior of the CDK menu item: * The item wasn't receiving focus like specified in the spec. * There wasn't a proper way to style disabled items which led users to use `aria-disabled`. * Clicking the disaled item didn't prevent the default behavior. Fixes angular#31179.
crisbeto
requested review from
adolgachev and
andrewseguin
and removed request for
a team
wagnermaciel
approved these changes
Aug 19, 2025
adolgachev
approved these changes
Aug 19, 2025
|
The changes were merged into the following branches: main, 20.1.x, 20.2.x |
crisbeto
added a commit
that referenced
this pull request
Aug 20, 2025
Fixes the following issues with the disabled behavior of the CDK menu item: * The item wasn't receiving focus like specified in the spec. * There wasn't a proper way to style disabled items which led users to use `aria-disabled`. * Clicking the disaled item didn't prevent the default behavior. Fixes #31179. (cherry picked from commit d61e35d)
crisbeto
added a commit
that referenced
this pull request
Aug 20, 2025
Fixes the following issues with the disabled behavior of the CDK menu item: * The item wasn't receiving focus like specified in the spec. * There wasn't a proper way to style disabled items which led users to use `aria-disabled`. * Clicking the disaled item didn't prevent the default behavior. Fixes #31179. (cherry picked from commit d61e35d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues with the disabled behavior of the CDK menu item:
aria-disabled.Fixes #31179.