Skip to content

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott requested a review from crisbeto August 25, 2025 20:25
@josephperrott josephperrott requested a review from a team as a code owner August 25, 2025 20:25
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 25, 2025
@josephperrott josephperrott requested review from adolgachev and removed request for a team August 25, 2025 20:25
@josephperrott josephperrott added the area: build & ci Related the build and CI infrastructure of the project label Aug 25, 2025
@alan-agius4
Copy link
Contributor

@josephperrott, can you also format the MODULE.bazel file as it seems that it is not formatted correctly, likely because ng-dev was only recently updated to format it.

@josephperrott
Copy link
Member Author

I confirmed that it is formatted as expected, even after manually updating to the latest ng-dev tooling and running the formatter.

@alan-agius4
Copy link
Contributor

alan-agius4 commented Aug 25, 2025

Strange as updating to the latest dev-infra causes the formatting check to fail

#31767

@alan-agius4 alan-agius4 removed the request for review from adolgachev August 25, 2025 20:50
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto merged commit 6997e5a into angular:main Aug 26, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants