feat(cdk-experimental/combobox): introduce new signals-based combobox #31872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Sep 15, 2025
wagnermaciel
commented
- Create the Combobox UI Pattern class
- Create the CdkCombobox, CdkComboboxInput, CdkComboboxPopupContent, and CdkComboboxPopup directives
- Create 3 component examples.
wagnermaciel
added
the
dev-app preview
angular-robot
bot
added
detected: feature
|
Deployed dev-app for ef511a3 to: https://ng-dev-previews-comp--pr-angular-components-31872-dev-jwmz3vug.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
wagnermaciel
force-pushed
the
combobox
branch
from
904893f to
d9ade63
Compare
ok7sai
reviewed
Sep 16, 2025
|
|
||
| export type ComboboxListboxInputs<V> = ListboxInputs<V> & { | ||
| /** The combobox controlling the listbox. */ | ||
| combobox: SignalLike<ComboboxPattern<OptionPattern<V>, V> | undefined>; |
There was a problem hiding this comment.
Since the pattern is separated from ListboxPattern I think it's fine to make the combobox not nullable to simplify the constructor logic.
There was a problem hiding this comment.
I tried making this change but it actually ends up complicating the constructor logic of the CdkListbox more than it simplifies the constructor of the popup pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.