-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(cdk/scrolling): Fix undefined error when documentElement.style is undefined #31904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to a single commit.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See linting error: commit and PR should use a valid component label: (cdk/scrolling) in this case.
Thanks! Updated the label |
Currently angular has a side effect which checks for scrollbehavior on module load. This is throwing an exception in our chrome extension content script when running on an xml page when style are undefined
Added a null check to make sure undefined exception is not thrown
