Skip to content

Conversation

abbasc52
Copy link
Contributor

Currently angular has a side effect which checks for scrollbehavior on module load. This is throwing an exception in our chrome extension content script when running on an xml page when style are undefined

Added a null check to make sure undefined exception is not thrown
image

@abbasc52 abbasc52 requested a review from a team as a code owner September 23, 2025 07:55
@abbasc52 abbasc52 requested review from mmalerba and andrewseguin and removed request for a team September 23, 2025 07:55
Copy link

google-cla bot commented Sep 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adolgachev adolgachev self-requested a review September 24, 2025 03:05
Copy link
Contributor

@adolgachev adolgachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to a single commit.

@adolgachev adolgachev added area: cdk/scrolling action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 24, 2025
@abbasc52
Copy link
Contributor Author

Please rebase to a single commit.

Done.

@abbasc52 abbasc52 requested a review from adolgachev September 24, 2025 09:22
@abbasc52 abbasc52 changed the title Fix document.documentElement.style undefined when using chrome extension on xml pages fix(cdk): Fix undefined error when documentElement.style is undefined Sep 25, 2025
Copy link
Contributor

@adolgachev adolgachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See linting error: commit and PR should use a valid component label: (cdk/scrolling) in this case.

@adolgachev adolgachev added target: patch This PR is targeted for the next patch release action: presubmit The PR is in need of a google3 presubmit labels Sep 25, 2025
@abbasc52 abbasc52 changed the title fix(cdk): Fix undefined error when documentElement.style is undefined fix(cdk/scrolling): Fix undefined error when documentElement.style is undefined Sep 26, 2025
@abbasc52
Copy link
Contributor Author

See linting error: commit and PR should use a valid component label: (cdk/scrolling) in this case.

Thanks! Updated the label

@abbasc52 abbasc52 requested a review from adolgachev September 26, 2025 12:30
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 26, 2025
@adolgachev adolgachev self-assigned this Sep 26, 2025
@adolgachev adolgachev removed the action: presubmit The PR is in need of a google3 presubmit label Sep 26, 2025
@adolgachev adolgachev merged commit 667a007 into angular:main Sep 26, 2025
23 of 25 checks passed
@adolgachev
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

adolgachev pushed a commit that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/scrolling target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants