fix(sidenav): fullscreen sidenavs should not scroll #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
kara
added
needs: discussion
googlebot
added
the
cla: yes
kara
added
pr: needs review
and removed
needs: discussion
kara
force-pushed
the
fullscreen
branch
2 times, most recently
from
2f1d240 to
a6240b6
Compare
kara
force-pushed
the
fullscreen
branch
2 times, most recently
from
3950194 to
d0f126c
Compare
| this._validateDrawers(); | ||
| } | ||
|
|
||
| private _watchSidenavToggle(sidenav: MdSidenav): void { |
There was a problem hiding this comment.
Add functions descriptions for these two
kara
force-pushed
the
fullscreen
branch
3 times, most recently
from
0e558c1 to
75632f9
Compare
|
LGTM |
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @jelbourn
This PR ensures that it's not possible to scroll past the sidenav backdrop when the sidenav is open.